Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link #4697

Merged
merged 4 commits into from
Jan 2, 2024
Merged

Fix link #4697

merged 4 commits into from
Jan 2, 2024

Conversation

nghi-ly
Copy link
Contributor

@nghi-ly nghi-ly commented Jan 2, 2024

What are you changing in this pull request and why?

Fix link in step 3 (https://docs.getdbt.com/guides/custom-cicd-pipelines?step=3 ) of the guide "Customizing CI/CD with custom pipelines guide".

It's pointing to itself when it should be pointing to step 2 of the guide for the "prior page".

Checklist

@nghi-ly nghi-ly requested a review from a team as a code owner January 2, 2024 20:33
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 10:06pm

@github-actions github-actions bot added content Improvements or additions to content guides Knowledge best suited for Guides size: x-small This change will take under 3 hours to fix. Docs team Authored by the Docs team @dbt Labs labels Jan 2, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Jan 2, 2024

shared feedback that the updated link doesn’t do anything or work in the staging link or in my local. not sure if it’s bc of how we’re linking it (e.g. [page](/guides/custom-cicd-pipelines?step=2)). it works if i use the full https [page](https://docs.getdbt.com/guides/custom-cicd-pipelines?step=2) however. but it opens a new page/tab.

Copy link
Contributor

@mirnawong1 mirnawong1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but the link change doesn't do anything to fix the behavior. maybe it'll work in prod

@nghi-ly
Copy link
Contributor Author

nghi-ly commented Jan 2, 2024

tested the draft again. confirmed. updated to using full URL which the original content was already doing.

@nghi-ly nghi-ly merged commit 00f9219 into current Jan 2, 2024
7 checks passed
@nghi-ly nghi-ly deleted the ly-docs-fix-link branch January 2, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs guides Knowledge best suited for Guides January-2024 size: x-small This change will take under 3 hours to fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants